Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skip_count is never incremented #146

Closed
aldesantis opened this issue Sep 9, 2020 · 1 comment · Fixed by #188
Closed

skip_count is never incremented #146

aldesantis opened this issue Sep 9, 2020 · 1 comment · Fixed by #188
Assignees
@AlessioRocco
Labels
bug Describes or fixes a bug.

Comments

@aldesantis
Copy link
Member

It looks like skip_count is not being incremented when skipping a subscription. There's simply no code in the extension that does it.
@stale
Copy link

stale bot commented Nov 8, 2020

This issue has been automatically marked as stale because it has not had recent activity. It might be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Nov 8, 2020
@AlessioRocco AlessioRocco mentioned this issue Jan 15, 2021
Merged
@AlessioRocco AlessioRocco self-assigned this Jan 15, 2021
@stale stale bot removed the stale label Jan 15, 2021
@AlessioRocco AlessioRocco added the bug Describes or fixes a bug. label Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlessioRocco AlessioRocco

Labels
bug Describes or fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix skip counters to handle skip limits solidusio/solidus_subscriptions
2 participants
@AlessioRocco @aldesantis