Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPS carrier doesn't allow empty company name in from_address #41

Closed
vassalloandrea opened this issue Sep 19, 2019 · 0 comments
Closed

Comments

@vassalloandrea
Copy link
Contributor

vassalloandrea commented Sep 19, 2019

Problem

UPS carrier doesn't allow an empty company name in the from_address object which is the stock_location object serialized.
This happens because the gem uses the same serializer for the shipment and the stock location.

attributes[:company] = company if respond_to?(:company)

The stock location hasn't the company attribute and it isn't sent to Easypost.

How to replicate

Try to ship a shipment with a UPS shipping method.

Possible solution

Use different easypost_address method for the stock location using the name as the company.

Screenshot

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant