Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move "vite" and "solid-js" to peer dependencies #36

Merged
merged 1 commit into from
May 7, 2022
Merged

move "vite" and "solid-js" to peer dependencies #36

merged 1 commit into from
May 7, 2022

Conversation

g-plane
Copy link
Contributor

@g-plane g-plane commented May 7, 2022

Close #35

@amoutonbrady
Copy link
Member

Thanks I quickly checked what svelte was doing and it seems like they do the same.

Thanks!

@amoutonbrady amoutonbrady merged commit f896d4d into solidjs:master May 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"vite" and "solid-js" should not be a dependency
2 participants
@g-plane @amoutonbrady