Extensions option added #24
Conversation
- added extensions option, which should contain list of additional extensions that should be also processed by vite-plugin-solid
src/index.ts
Outdated
| if (id.includes('tsx')) { | ||
| opts.presets.push([ts, options.typescript || {}]); | ||
| } |
There was a problem hiding this comment.
@high1 Can we keep this format? I prefer things to be explicit rather than one liners. It eases the readability in my opinion.
There was a problem hiding this comment.
I've did this because
if (!/.[jt]sx/.test(id)) return null;
line 296
src/index.ts
Outdated
| if (!(/\.[jt]sx/.test(id) || options.extensions?.includes(getExtension(id).split('?')[0]))) | ||
| return null; | ||
|
|
There was a problem hiding this comment.
@high1 I'd prefer to break that into two different steps to improve readability.
Something like that:
| if (!(/\.[jt]sx/.test(id) || options.extensions?.includes(getExtension(id).split('?')[0]))) | |
| return null; | |
| if (options.extensions) { | |
| const extension = getExtension(id); | |
| const [extensionWithoutMdFlag] = extension.split('?'); | |
| if (options.extensions.includes(extensionWithoutMdFlag)) return null | |
| } | |
| if (!(/\.[jt]sx/.test(id)) return null; | |
There was a problem hiding this comment.
Sure, I have some kind of passion for one liners, but those can be hard to read...
There was a problem hiding this comment.
Totally get it, I too have this thing, it's really a JS thing haha
The issue here is that I want anyone to be able to come in and be able to contribute without having to worry about code structure.
If we had another check to do within that if, that person would have to add { }
|
As per discussions, I also think its a good idea to have the options passed with the extensions be an object with config for the compiler.. This will allow us to add more options if we need them (and considering the compiler approach, its probably going to require configuration for like custom renderers, etc). |
- made everything more explicit, as requested
- added optional typescript opt-in behavior per extension, like
['.solid', { typescript: true }]
- check if options.extensions is defined before calling find
extensions that should be also processed by vite-plugin-solid