Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

peerDependencyMeta in package.json should be peerDependenciesMeta #139

Closed
ulrichstark opened this issue Jan 23, 2024 · 0 comments · Fixed by #140
Closed

peerDependencyMeta in package.json should be peerDependenciesMeta #139

ulrichstark opened this issue Jan 23, 2024 · 0 comments · Fixed by #140

Comments

@ulrichstark
Copy link
Contributor

PR #136 added peerDependencyMeta to package.json to make peer dependency @testing-library/jest-dom optional.
It should have been peerDependenciesMeta to work as expected.
I will link a PR to fix this issue in a minute.
Thank you all for your work on solidjs and its ecosystem.
I'm a big fan!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

change wrong peerDependencyMeta to peerDependenciesMeta
1 participant
@ulrichstark