Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove map and createStore from mount.ts #1650

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

thetarnav
Copy link
Contributor

I don't know if I'm missing something or is this a leftover, but the weak map is only being written to and the props object doesn't get changed, so it doesn't need to be a store.
I don't like when stores are added to the bundle for no reason.

Copy link

changeset-bot bot commented Oct 8, 2024

⚠️ No Changeset found

Latest commit: 680940d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ryansolid
Copy link
Member

It's because the implementation present here is only half of the implementation. The Store was there when we had islands routing mode which could write to the props.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants