Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Content]: [Content]: "Portals" are used before they are introduced #1057

Open
boazr-neosec opened this issue Feb 3, 2025 · 0 comments
Open
Assignees
Labels
pending review Awaiting review by team members.

Comments

@boazr-neosec
Copy link

📚 Subject area/topic

/concepts/components/event-handlers.mdx

📋 Page(s) affected (or suggested, for new content)

https://docs.solidjs.com/concepts/components/event-handlers

📋 Description of content that is out-of-date or incorrect

on the 'events' doc page 'Portals' are mentioned and used but it's unclear to the reader what they are. In fact, they are mentioned here for the first time so the reader might know even know such an entity exists in the world of Solid.
At minimum, add a reference to 'Portals' section but maybe just a few words on them would do even better:

Portals (which allow rendering content outside of the regular document flow, see more here) propagate events following the component tree and not the DOM tree, making them easier to use. This means when a Portal gets attached to the body, any events will propagate up to the container."

🖥️ Reproduction in StackBlitz (if reporting incorrect content or code samples)

No response

@boazr-neosec boazr-neosec added the pending review Awaiting review by team members. label Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending review Awaiting review by team members.
Projects
None yet
Development

No branches or pull requests

2 participants