Skip to content
This repository has been archived by the owner on Sep 17, 2024. It is now read-only.

Portal tutorial page popup has poor text color contrast on dark mode #216

Open
samstorment opened this issue Dec 4, 2022 · 1 comment
Open

Portal tutorial page popup has poor text color contrast on dark mode #216

samstorment opened this issue Dec 4, 2022 · 1 comment
Labels
bug Something isn't working tutorial Related to the tutorial

Comments

@samstorment
Copy link

Describe the bug

The popup on the Portal tutorial page has a very lightly colored background and uses white text when dark mode is enabled.

Your Example Website or App

https://www.solidjs.com/tutorial/flow_portal?solved

Steps to Reproduce the Bug or Issue

  1. Navigate to https://www.solidjs.com/tutorial/flow_portal?solved
  2. Turn on dark mode
  3. View the popup in the playground

Expected Behavior

High contrast text on the popup.

Screenshots or Videos

image

Platform

  • OS: Windows 11
  • Browser:
    • Firefox: Version 107.0.1 (64-bit)
    • Edge: Version 107.0.1418.62 (Official build) (64-bit)
@orenelbaum orenelbaum added bug Something isn't working tutorial Related to the tutorial labels Dec 4, 2022
@joaobarata
Copy link
Contributor

#210 should address this issue

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working tutorial Related to the tutorial
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@joaobarata @samstorment @orenelbaum