-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trial Metadata Upload #5248
Open
dwaring87
wants to merge
15
commits into
master
Choose a base branch
from
topic/batch_update_trials
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Trial Metadata Upload #5248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds a new upload option to the Manage > Field Trials page for uploading "Trial Metadata". This allows a user to upload new trial-level metadata for existing trials. Supported metadata:
To update a trial, a user must be a curator or (a submitter and a member of the breeding program - both the original and new breeding program, if it's being updated).
It also fixes a bug with the refresh trial tree functions. There was often a race condition when hiding the working modal after uploading a new file and showing the working modal when starting the tree refresh. This resulted in the working modal being stuck after the refresh was complete. I added a short (0.5 second) timeout before starting the refresh to help prevent this.
Fixes #5236
Checklist
/t/data/fixture/patches/
./docs
has been updated./js
to/js/source/legacy
.