Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fake wallet does not render SVG icons #56

Closed
steveluscher opened this issue Jun 18, 2022 · 2 comments
Closed

Fake wallet does not render SVG icons #56

steveluscher opened this issue Jun 18, 2022 · 2 comments

Comments

@steveluscher
Copy link
Contributor

We should consider making the fake wallet app able to render any reasonable kind of icon, or should specify which image formats are allowed. Right now it doesn't appear to render SVG files.

@sdlaver
Copy link
Contributor

sdlaver commented Jun 20, 2022

I'll add support for SVG rendering to fakewallet. That seems like a reasonable expectation to set, and fake wallet will, for better or worse, end up implicitly defining much of the standard implementation.

@devacros
Copy link

I opened a PR regarding this

#73

Coil library will make it easier to support svg and regular images at the same time on the fakewallet app ( I guess at the end of the day the wallet developer can use any library)

Ideally the AuthorizeRequest can have a getIdentifyType method which lets the wallet know that it needs to display a svg, png, gif, etc.

@sdlaver sdlaver closed this as completed Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants