Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reinstate commitment param to support old clients #9324

Merged
merged 1 commit into from
Apr 6, 2020
Merged

Reinstate commitment param to support old clients #9324

merged 1 commit into from
Apr 6, 2020

Conversation

CriesofCarrots
Copy link
Contributor

@CriesofCarrots CriesofCarrots commented Apr 6, 2020 •
edited
Loading

Problem

Using an old client/cli with the new rpc results in commitment-related errors:

$ solana airdrop 10 --url http://devnet.solana.com

Requesting airdrop of 10 SOL from 35.233.193.70:9900
Error: rpc request error: RPC Error response: {"code":-32602,"message":"Invalid params: missing field searchTransactionHistory."}

Summary of Changes

  • Reinstate commitment to support old clients, mark as deprecated to be removed on next client release

Replaces #9323

@CriesofCarrots CriesofCarrots added v1.0 automerge Merge this Pull Request automatically once CI passes labels Apr 6, 2020
@solana-grimes solana-grimes removed the automerge Merge this Pull Request automatically once CI passes label Apr 6, 2020
@solana-grimes
Copy link
Contributor

💔 Unable to automerge due to CI failure

@CriesofCarrots CriesofCarrots added the automerge Merge this Pull Request automatically once CI passes label Apr 6, 2020
@solana-grimes solana-grimes merged commit cc07c86 into solana-labs:v1.1 Apr 6, 2020
CriesofCarrots added a commit to CriesofCarrots/solana that referenced this pull request Apr 6, 2020
@CriesofCarrots
Reinstate commitment param to support old clients (solana-labs#9324)
52aac30 
automerge
@mvines
Copy link
Member

mvines commented Apr 6, 2020

@Mergifyio backport v1.0

@mvines
Copy link
Member

mvines commented Apr 6, 2020

oh, nm!

@CriesofCarrots CriesofCarrots mentioned this pull request Apr 6, 2020
Merged
@mergify
Copy link
Contributor

mergify bot commented Apr 6, 2020

Command backport v1.0: success

Backports have been created

mergify bot pushed a commit that referenced this pull request Apr 6, 2020
@CriesofCarrots
Reinstate commitment param to support old clients (#9324)
2bdaf58 
automerge

(cherry picked from commit cc07c86)
@mergify mergify bot mentioned this pull request Apr 6, 2020
Closed
solana-grimes pushed a commit that referenced this pull request Apr 6, 2020
@CriesofCarrots
Reinstate commitment param to support old clients (#9324) (#9329)
0936736 
automerge
@CriesofCarrots CriesofCarrots deleted the v1.1-sig-status-support-versions branch April 16, 2020 17:38
@CriesofCarrots CriesofCarrots mentioned this pull request May 19, 2020
Closed
This was referenced Oct 11, 2023
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced May 12, 2024
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
@BuloZB BuloZB mentioned this pull request May 19, 2024
Open
This was referenced May 21, 2024
Open
Open
Open
Open
Open
Open
This was referenced Oct 12, 2024
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
automerge Merge this Pull Request automatically once CI passes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CriesofCarrots @solana-grimes @mvines