adds Merkle shred variant with retransmitter's signature #35293
Conversation
behzadnouri
force-pushed
the
shred-variant-resigned
branch
2 times, most recently
from
8a1a32c
to
4d2ef93
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #35293 +/- ##
=========================================
- Coverage 81.7% 81.7% -0.1%
=========================================
Files 834 834
Lines 224235 224288 +53
=========================================
+ Hits 183390 183431 +41
- Misses 40845 40857 +12 |
behzadnouri
force-pushed
the
shred-variant-resigned
branch
2 times, most recently
from
ed91d2d
to
f4e95fc
Compare
behzadnouri
requested review from
carllin,
steviez,
AshwinSekar and
bw-solana
behzadnouri
force-pushed
the
shred-variant-resigned
branch
from
f4e95fc
to
f61204f
Compare
| @@ -148,12 +150,14 @@ impl ShredData { | |||
| // ShredCode::capacity(proof_size).unwrap() | |||
| // - ShredData::SIZE_OF_HEADERS | |||
There was a problem hiding this comment.
I see that ShredCode::capacity already subtracts ShredCode::SIZE_OF_HEADERS. Should this be
- (ShredData::SIZE_OF_HEADERS - ShredCode::SIZE_OF_HEADERS)
There was a problem hiding this comment.
I think this is correct as is, and is described why here:
https://github.com/solana-labs/solana/blob/8ad125d0c/ledger/src/shred.rs#L5-L50
We also have a test for this:
https://github.com/solana-labs/solana/blob/8ad125d0c/ledger/src/shred/merkle.rs#L1338-L1347
There was a problem hiding this comment.
got it, so since the data header is also erasure coded and data shred must be the same length of coding shred, we add the restricted section, which is the size of the coding shred header.
Moving towards locking down Turbine propagation path, the commit reserves a buffer within shred payload for retransmitter's signature.
behzadnouri
force-pushed
the
shred-variant-resigned
branch
from
f61204f
to
1f853c4
Compare
|
Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis. |
Moving towards locking down Turbine propagation path, the commit reserves a buffer within shred payload for retransmitter's signature. (cherry picked from commit a7a41e7)
…port of #35293) (#35357) adds Merkle shred variant with retransmitter's signature (#35293) Moving towards locking down Turbine propagation path, the commit reserves a buffer within shred payload for retransmitter's signature. (cherry picked from commit a7a41e7) Co-authored-by: behzad nouri <[email protected]>
Problem
Locking down Turbine propagation path.
Summary of Changes
Added Merkle shred variant with reserved buffer for retransmitter's signature.