Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V1.18 revert #34865 #35007

Closed
wants to merge 1 commit into from
Closed

V1.18 revert #34865 #35007

wants to merge 1 commit into from

Conversation

willhickey
Copy link
Contributor

#34865 introduced a hash mismatch. Reverting for now so testnet can adopt v1.18.1

tao-stones
tao-stones previously approved these changes Jan 29, 2024
Copy link
Contributor

@tao-stones tao-stones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@willhickey willhickey changed the base branch from v1.18 to master January 29, 2024 19:54
@willhickey willhickey dismissed tao-stones’s stale review January 29, 2024 19:54

The base branch was changed.

@willhickey willhickey changed the base branch from master to v1.18 January 29, 2024 19:54
@willhickey willhickey mentioned this pull request Jan 29, 2024
@willhickey
Copy link
Contributor Author

I just realized this behavior is the same between master and v1.18. Closing this in favor of a master PR and automatic backport.

@willhickey willhickey closed this Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants