Adds cache hash data deletion policy enum #34956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis. |
brooksprumo
force-pushed
the
hash-cache/delete-policy
branch
from
67ad931
to
5aa5b03
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #34956 +/- ##
=========================================
- Coverage 81.6% 81.6% -0.1%
=========================================
Files 828 830 +2
Lines 224339 224661 +322
=========================================
+ Hits 183274 183529 +255
- Misses 41065 41132 +67 |
mergify bot
pushed a commit
that referenced
this pull request
Jan 25, 2024
(cherry picked from commit e155d9c)
brooksprumo
added a commit
that referenced
this pull request
Jan 26, 2024
…#34962) Adds cache hash data deletion policy enum (#34956) (cherry picked from commit e155d9c) Co-authored-by: Brooks <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When working on #34933 to clean up stale account hash cache files, there was a suggestion for improving the code that ultimately did not make it into the PR itself: use an enum for the deletion policy instead of
Option.Original comment: #34933 (comment)
Summary of Changes
Add a deletion policy enum.