Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix epoch rewards partition-data program owner #34913

Merged

Conversation

CriesofCarrots
Copy link
Contributor

Problem

#34862 attempted to change the program-owner of the epoch rewards partition-data PDAs. However, the runtime constructs the account manually, so the owner needs to be updated there too.

Summary of Changes

Fix owner assignment

Sorry, dumb bug

Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e74f04a) 81.6% compared to head (e18928f) 81.6%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master   #34913     +/-   ##
=========================================
- Coverage    81.6%    81.6%   -0.1%     
=========================================
  Files         827      827             
  Lines      223846   223846             
=========================================
- Hits       182823   182773     -50     
- Misses      41023    41073     +50     

@CriesofCarrots CriesofCarrots merged commit 7ebe0bc into solana-labs:master Jan 23, 2024
35 checks passed
CriesofCarrots added a commit to CriesofCarrots/solana that referenced this pull request Jan 24, 2024
@CriesofCarrots
Copy link
Contributor Author

Aw, missed v1.18 😞

@CriesofCarrots CriesofCarrots added the v1.18 PRs that should be backported to v1.18 label Jan 24, 2024
Copy link
Contributor

mergify bot commented Jan 24, 2024

Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis.

mergify bot pushed a commit that referenced this pull request Jan 24, 2024
Fix account program owner

(cherry picked from commit 7ebe0bc)
CriesofCarrots added a commit that referenced this pull request Jan 24, 2024
…4913) (#34924)

Fix epoch rewards partition-data program owner (#34913)

Fix account program owner

(cherry picked from commit 7ebe0bc)

Co-authored-by: Tyera <[email protected]>
CriesofCarrots added a commit to CriesofCarrots/solana that referenced this pull request Feb 2, 2024
CriesofCarrots added a commit that referenced this pull request Feb 6, 2024
mergify bot pushed a commit that referenced this pull request Feb 6, 2024
CriesofCarrots added a commit that referenced this pull request Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v1.18 PRs that should be backported to v1.18
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants