blockstore: Make is_orphan() a method of SlotMeta #34889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steviez
force-pushed
the
bstore_meta_orphan
branch
from
b258357
to
8db3b37
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #34889 +/- ##
=======================================
Coverage 81.7% 81.7%
=======================================
Files 826 826
Lines 223413 223413
=======================================
+ Hits 182614 182627 +13
+ Misses 40799 40786 -13 |
steviez
requested review from
brooksprumo and
bw-solana
and removed request for
brooksprumo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Move the method whose sole input is a
SlotMetato be a method of theSlotMetaobject