Uses accounts run and snapshot dir constants #34879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brooksprumo
force-pushed
the
errors/accounts-dir-constants
branch
from
6424c1a
to
976b973
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #34879 +/- ##
=========================================
- Coverage 81.7% 81.6% -0.2%
=========================================
Files 826 827 +1
Lines 223413 223819 +406
=========================================
+ Hits 182614 182678 +64
- Misses 40799 41141 +342 |
brooksprumo
force-pushed
the
errors/accounts-dir-constants
branch
from
976b973
to
ab4fe21
Compare
apfitzge
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The accounts run and snapshot directories are
runandsnapshot, respectively. We have constants for these, but they are not always used.Summary of Changes
Uses accounts run and snapshot dir constants