Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes fs-err dependency from accounts-db crate #34869

Merged

Conversation

brooksprumo
Copy link
Contributor

Problem

The fs-err dependency is not used by the accounts-db crate.

Summary of Changes

Remove it.

@brooksprumo brooksprumo self-assigned this Jan 22, 2024
@brooksprumo brooksprumo marked this pull request as ready for review January 22, 2024 04:42
Copy link

codecov bot commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f9bfb60) 81.7% compared to head (cb30344) 81.7%.

Additional details and impacted files
@@            Coverage Diff            @@
##           master   #34869     +/-   ##
=========================================
- Coverage    81.7%    81.7%   -0.1%     
=========================================
  Files         826      826             
  Lines      223371   223371             
=========================================
- Hits       182578   182539     -39     
- Misses      40793    40832     +39     

Copy link
Member

@yihau yihau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🫶

@brooksprumo brooksprumo merged commit d005b3a into solana-labs:master Jan 22, 2024
46 checks passed
@brooksprumo brooksprumo deleted the fs-err/remove/accounts-db branch January 22, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants