Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
get_io_error()
's name is somewhat confusing, and the function is also limited by only supportingstr
string inputs. It also always logs awarn!()
, but often the callers will also log the error later, which is redundant.Summary of Changes
Replace
get_io_error()
withstd::io::Error::other()
, which accepts anything that implementsstd::error::Error
. Also add more information to these errors.