Define epoch-rewards partition data program id #34862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CriesofCarrots
force-pushed
the
epoch-rewards-prog-id
branch
from
9d29d34
to
b329e89
Compare
CriesofCarrots
force-pushed
the
epoch-rewards-prog-id
branch
from
b329e89
to
6907fd4
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #34862 +/- ##
=========================================
- Coverage 81.8% 81.7% -0.1%
=========================================
Files 825 825
Lines 223269 223269
=========================================
- Hits 182635 182580 -55
- Misses 40634 40689 +55 |
CriesofCarrots
added a commit
to CriesofCarrots/solana
that referenced
this pull request
Feb 2, 2024
CriesofCarrots
added a commit
that referenced
this pull request
Feb 6, 2024
This reverts commit 8aa726b.
CriesofCarrots
added a commit
that referenced
this pull request
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
If the epoch-rewards partition data accounts are owned by the Stake program, parsers try to deserialize them as StakeState variants. This feels icky.
Summary of Changes
Use the sysvar program id to own these PDAs
Also, remove storage of HasherKind to save 4 bytes and provide mapping fn instead.