-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sample peers if input peer missing for repair shred #34818
Sample peers if input peer missing for repair shred #34818
Conversation
c81944a
to
b9cbeaa
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #34818 +/- ##
=========================================
- Coverage 81.8% 81.7% -0.1%
=========================================
Files 825 825
Lines 223269 223317 +48
=========================================
- Hits 182635 182603 -32
- Misses 40634 40714 +80 |
868075d
to
48dcfd2
Compare
29a04b7
to
fd3082b
Compare
fd3082b
to
b91e60b
Compare
Everything still appears to be working after the latest changes to use cluster slots and take a weighted sampling:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Problem
This builds off of #34771. The repair-shred-from-peer command currently requires a valid peer pubkey to be provided as input and a valid repair socket to exist in cluster info. In the event no pubkey or an invalid pubkey is provided, it would be nice to log this and then sample a random set of validators instead. The idea here is that one of the validators should possess
Summary of Changes
For testing, spun up a node on testnet and tried issuing this command with the following pubkey inputs:
9YVpEeZf8uBoUtzCFC6SSFDDqPt16uKFubNhLvGxeUDy
<-- we requested repair from only this node9YVpEeZf8uBoUtzCFC6SSFDDqPt16uKFubNhLvGxeUD
<-- we requested repair from random 10 nodes