Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[zk-token-sdk] Restrict a single-bit of 256-bit batched range proof to 128 #34803

Merged
merged 2 commits into from
Jan 18, 2024
Merged

[zk-token-sdk] Restrict a single-bit of 256-bit batched range proof to 128 #34803

merged 2 commits into from
Jan 18, 2024

Conversation

samkim-crypto
Copy link
Contributor

@samkim-crypto samkim-crypto commented Jan 17, 2024

Problem

The problem is shared with #34747.

Summary of Changes

Restrict the bit-length in a 256-bit range proof to 128.

This is a follow-up to #34747. Since this part of the logic is gated, it does not need to be backported.

Fixes #

@samkim-crypto samkim-crypto added the work in progress This isn't quite right yet label Jan 17, 2024
Copy link

codecov bot commented Jan 17, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (9edf65b) 81.8% compared to head (2abf398) 81.8%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master   #34803     +/-   ##
=========================================
- Coverage    81.8%    81.8%   -0.1%     
=========================================
  Files         825      825             
  Lines      223160   223166      +6     
=========================================
- Hits       182559   182553      -6     
- Misses      40601    40613     +12     

@samkim-crypto samkim-crypto removed the work in progress This isn't quite right yet label Jan 17, 2024
Copy link
Contributor

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@samkim-crypto samkim-crypto merged commit e2c2029 into solana-labs:master Jan 18, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants