removed obsolete field from cost_tracker #34762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tao-stones
force-pushed
the
remove-account-data-size-limit
branch
from
fd5b7b3
to
c506f37
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #34762 +/- ##
=======================================
Coverage 81.7% 81.7%
=======================================
Files 823 823
Lines 223050 223006 -44
=======================================
- Hits 182409 182402 -7
+ Misses 40641 40604 -37 |
brooksprumo
approved these changes
Jan 12, 2024
Comment on lines
-206
to
-210
| if let Some(account_data_size_limit) = self.account_data_size_limit { | ||
| if account_data_size > account_data_size_limit { | ||
| return Err(CostTrackerError::WouldExceedAccountDataTotalLimit); | ||
| } | ||
| } |
There was a problem hiding this comment.
GitHub won't let me comment on the line, but up on line (old) 201/(new) 187, the NOTE mentions checking the total size before the block size. Now that we do not check the total size, that comment can be updated.
Not a blocker for this PR, as it can be fixed in a subsequent one.
There was a problem hiding this comment.
thanks for point it out. Will clean it up separately
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
After #34688,
CostTracker.account_data_size_limitbecomes obsolete.Summary of Changes
Fixes #