Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move EMA and stream throttling code to a new file #34759

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

pgarg66
Copy link
Contributor

@pgarg66 pgarg66 commented Jan 11, 2024

Problem

The quic.rs file is getting bloated, and some code could be moved out.

Summary of Changes

Move stream throttling related code to stream_throttle.rs.

Fixes #

@pgarg66 pgarg66 marked this pull request as ready for review January 11, 2024 23:38
@pgarg66 pgarg66 requested a review from t-nelson January 11, 2024 23:39
Copy link

codecov bot commented Jan 11, 2024

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (a203f14) 81.7% compared to head (dd8b510) 81.8%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #34759   +/-   ##
=======================================
  Coverage    81.7%    81.8%           
=======================================
  Files         823      824    +1     
  Lines      223050   223051    +1     
=======================================
+ Hits       182409   182456   +47     
+ Misses      40641    40595   -46     

Copy link
Contributor

@t-nelson t-nelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@pgarg66 pgarg66 merged commit 22fcffe into solana-labs:master Jan 12, 2024
35 checks passed
@pgarg66 pgarg66 deleted the ema-follow-up branch January 12, 2024 00:55
lijunwangs pushed a commit to lijunwangs/solana that referenced this pull request Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants