[zk-token-proof] Add functionality to read proof from accounts instead of instruction data #34750
Conversation
programs/zk-token-proof/src/lib.rs
Outdated
| *bytemuck::try_from_bytes::<T>(proof_data).map_err(|_| { | ||
| ic_msg!(invoke_context, "invalid proof data"); | ||
| InstructionError::InvalidInstructionData | ||
| })? | ||
| } else { | ||
| *ProofInstruction::proof_data::<T, U>(instruction_data).ok_or_else(|| { | ||
| ic_msg!(invoke_context, "invalid proof data"); | ||
| InstructionError::InvalidInstructionData | ||
| })? |
There was a problem hiding this comment.
To avoid cloning the whole proof data here, how about verifying the proof in each branch, and then have it return the context? That way you're copying a lot less data, right?
There was a problem hiding this comment.
Yep, very good idea!
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #34750 +/- ##
=========================================
- Coverage 81.8% 81.8% -0.1%
=========================================
Files 824 824
Lines 222692 222742 +50
=========================================
- Hits 182314 182308 -6
- Misses 40378 40434 +56 |
Co-authored-by: Jon C <[email protected]>
There was a problem hiding this comment.
These tests are all really good!
sdk/src/feature_set.rs
Outdated
| @@ -760,6 +760,10 @@ pub mod deprecate_executable_meta_update_in_bpf_loader { | |||
| solana_sdk::declare_id!("k6uR1J9VtKJnTukBV2Eo15BEy434MBg8bT6hHQgmU8v"); | |||
| } | |||
|
|
|||
| pub mod enable_zk_from_account { | |||
There was a problem hiding this comment.
nit-up-to-you: maybe we can call it enable_zk_proof_from_account to be clearer?
There was a problem hiding this comment.
Okay, yes that will be clearer.
Co-authored-by: Jon C <[email protected]>
Co-authored-by: Jon C <[email protected]>
|
Thanks for catching some of my sloppy mistakes 🙏 |
Problem
Some of the proofs in the zk-token-proof program is too large to fit in a single transaction.
Summary of Changes
Update the proof program so that users can provide the zkp as either part of the instruction data or as an account data.
still TODO:
Fixes #