Removes unnecessary feature activation when testing accounts data size #34701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #34701 +/- ##
=======================================
Coverage 81.8% 81.8%
=======================================
Files 824 824
Lines 222687 222686 -1
=======================================
+ Hits 182245 182282 +37
+ Misses 40442 40404 -38 |
brooksprumo
commented
Jan 9, 2024
Comment on lines
+10267
to
+10269
| let (genesis_config, _mint_keypair) = create_genesis_config(1_000 * LAMPORTS_PER_SOL); | ||
| let bank = Bank::new_for_tests(&genesis_config); | ||
| let bank = bank.wrap_with_bank_forks_for_tests().0; |
There was a problem hiding this comment.
I also took this opportunity to make the bank creation part here identical to what's in test_accounts_data_size_with_good_transaction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Some Bank tests activate the
cap_accounts_data_lenfeature unnecessarily.Summary of Changes
Remove 'em.