Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TransactionScheduler: Add funded check before graph insertion #34699

Merged

Conversation

apfitzge
Copy link
Contributor

@apfitzge apfitzge commented Jan 8, 2024

Problem

  • Invalid fee-paying transactions can get inserted into the graph, and take up place in batches which can delay valid transactions.

Summary of Changes

Blocked by #34652

Fixes #

Copy link

codecov bot commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (98a2873) 81.8% compared to head (5d35e12) 81.8%.

Additional details and impacted files
@@            Coverage Diff            @@
##           master   #34699     +/-   ##
=========================================
- Coverage    81.8%    81.8%   -0.1%     
=========================================
  Files         825      825             
  Lines      223105   223142     +37     
=========================================
+ Hits       182555   182583     +28     
- Misses      40550    40559      +9     

@apfitzge apfitzge force-pushed the scheduler_earlier_fee_payer_validation branch from cc756c3 to 307b58f Compare January 9, 2024 17:05
@apfitzge apfitzge marked this pull request as ready for review January 9, 2024 17:06
@apfitzge apfitzge requested review from tao-stones and removed request for tao-stones January 9, 2024 17:06
@apfitzge apfitzge marked this pull request as draft January 10, 2024 18:34
@apfitzge apfitzge force-pushed the scheduler_earlier_fee_payer_validation branch from 307b58f to c1ce2a8 Compare January 11, 2024 19:46
@tao-stones
Copy link
Contributor

Probably can be refreshed by #34666 before reviewing

@apfitzge apfitzge force-pushed the scheduler_earlier_fee_payer_validation branch from c1ce2a8 to 5d35e12 Compare January 12, 2024 16:30
@apfitzge apfitzge marked this pull request as ready for review January 12, 2024 16:30
Copy link
Contributor

@tao-stones tao-stones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@apfitzge apfitzge merged commit beef847 into solana-labs:master Jan 12, 2024
35 checks passed
@apfitzge apfitzge deleted the scheduler_earlier_fee_payer_validation branch January 12, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants