Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

security-policy: Refer to SPL for on-chain programs #34697

Merged
merged 4 commits into from
Jan 9, 2024

Conversation

joncinque
Copy link
Contributor

Problem

It's not clear that the SPL has its own security policy for those just looking at the monorepo security policy, and in fact confused a few people.

Summary of Changes

In the "Out of Scope" section, add a link to the SPL security policy.

Fixes #

SECURITY.md Outdated
Comment on lines 137 to 141
The Solana Program Library has its own security policy for on-chain programs,
such as spl-token, which is not covered here. For more information, please refer
to the
[SPL security policy](https://github.com/solana-labs/solana-program-library/security/policy).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wdyt about shortening to a new item in the bulleted list and adding something similar at in the first section of the doc? "Please report Solana Program Library (SPL) vulns to ..."

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

were you planning to add similar at the top of the doc or nah?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah sorry, it looks like I was in "review" mode and not "respond to comment" mode, so my response didn't get published.

I wasn't sure where to put it at the top, so it seemed easiest to just add the point in the list.

I did notice that "token" is called out in the "loss of funds" section though on line 101. Do you want to keep that there or should I remove it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah sorry, it looks like I was in "review" mode and not "respond to comment" mode, so my response didn't get published.

👍

I wasn't sure where to put it at the top, so it seemed easiest to just add the point in the list.

i was thinking up there under the big bold "DO NOT CREATE A GITHUB ISSUE..."

I did notice that "token" is called out in the "loss of funds" section though on line 101. Do you want to keep that there or should I remove it?

oh yeah that should definitely be gone

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i was thinking up there under the big bold "DO NOT CREATE A GITHUB ISSUE..."

I think I put it in the right place, let me know. It read awkwardly to me right after the bold bit, but let me know if you prefer something else

oh yeah that should definitely be gone

Done

Copy link
Contributor

@t-nelson t-nelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! :shipit:

@joncinque joncinque merged commit e681d8b into solana-labs:master Jan 9, 2024
9 checks passed
@joncinque joncinque deleted the splsec branch January 9, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants