Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust blockstore open logs to say blockstore instead of database #34672

Merged
merged 1 commit into from
Jan 6, 2024

Conversation

steviez
Copy link
Contributor

@steviez steviez commented Jan 5, 2024

Problem

Grepping logs, one is probably inclined to search for blockstore (the name of the higher level object in the source code) instead of database.

Summary of Changes

  • Use blockstore in place of database
  • Make the log after the open operation more similar to one prior to make it more clear that they are the before/after

Before this PR:

[...  solana_ledger::blockstore] Opening database at "/home/sol/ledger/rocksdb
[...  solana_ledger::blockstore] "/home/sol/ledger/rocksdb" open took 895ms

And after this PR:

[...  solana_ledger::blockstore] Opening blockstore at "/home/sol/ledger/rocksdb
[...  solana_ledger::blockstore] Opening blockstore done; blockstore open took 895ms

Additionally, make the log before/after the open more similar so it is
more clear while skimming logs that they correspond to each other.
@steviez steviez requested a review from t-nelson January 5, 2024 21:43
@steviez
Copy link
Contributor Author

steviez commented Jan 5, 2024

@t-nelson - Adding you as I think we have shared similar disdain for "asymmetric" starting/done logs elsewhere in the codebase

Copy link

codecov bot commented Jan 5, 2024

Codecov Report

Attention: 521 lines in your changes are missing coverage. Please review.

Comparison is base (835183a) 81.8% compared to head (eb31176) 81.8%.
Report is 1674 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #34672      +/-   ##
==========================================
  Coverage    81.8%    81.8%              
==========================================
  Files         767      824      +57     
  Lines      209297   222488   +13191     
==========================================
+ Hits       171276   182119   +10843     
- Misses      38021    40369    +2348     

Copy link
Contributor

@t-nelson t-nelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@steviez steviez merged commit dce3ce3 into solana-labs:master Jan 6, 2024
35 checks passed
@steviez steviez deleted the bstore_open_log branch January 6, 2024 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants