Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

ledger-tool: Minor cleanup on accountsdb config argument parsing #34671

Merged

Conversation

steviez
Copy link
Contributor

@steviez steviez commented Jan 5, 2024

Summary of Changes

Really minor change here; made the change as part of something else but decided to break it out to avoid cluttering the other PR

  • Avoid parsing the accounts_index_path twice when it is present
  • Reorder the parsing so that the "associated" items appear next to each other. Namely, put all of the parts of AccountsIndexConfig next to each other instead of having the test_partitioned_epoch_rewards smack in the middle of it

Copy link

codecov bot commented Jan 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b814497) 81.8% compared to head (549beab) 81.8%.
Report is 5 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #34671   +/-   ##
=======================================
  Coverage    81.8%    81.8%           
=======================================
  Files         824      824           
  Lines      222394   222394           
=======================================
+ Hits       181957   182054   +97     
+ Misses      40437    40340   -97     

@steviez steviez requested a review from gregcusack January 5, 2024 21:40
Copy link
Contributor

@gregcusack gregcusack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. apologies for the slow review 😑

@steviez steviez merged commit 4839115 into solana-labs:master Jan 9, 2024
20 checks passed
@steviez steviez deleted the lt_get_accounts_db_config_cleanup branch January 9, 2024 22:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants