ledger-tool: Adjust logic to obtain TransactionStatusService Blockstore

[steviez]

Problem

TransactionStatusService needs Primary access in order to write
transaction status into the Blockstore if enable_rpc_transaction_history
is set to True. The current logic attempts to get Primary access for the
service.

Summary of Changes

However, in the event that this function had been called with a
Blockstore that already had Primary access, this second attempt to get
Primary access would fail. So, only attempt to open with Primary access
when necessary AND when the current access level is not sufficient.

Note that this function is currently called with Secondary (read only) blockstore access. So, we would not currently run into this error with the default. Someone setting several flags in a particular manner could technically encounter this error.

Regardless, there is no requirement about the access type of the Blockstore passed into load_and_process_ledger(). So, this change is more defensive in the event that we start calling this function with Primary access, or if someone happens to provide the exact combination of args to hit the error that this change prevents

[steviez]

The only logic change was the addition of && !blockstore.is_primary_access() to this line (first commit). It is unintuitive to me that this change would make the linter want to adjust lines for the if statement that encloses this line (and other stuff), but that is what cargo fmt wanted so 🤷

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0b49d82) 81.8% compared to head (d5a1f5c) 81.8%.
Report is 2 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master   #34646   +/-   ##
=======================================
  Coverage    81.8%    81.8%           
=======================================
  Files         824      824           
  Lines      222393   222393           
=======================================
+ Hits       181954   181972   +18     
+ Misses      40439    40421   -18     

[CriesofCarrots]

Ah cool... I was wondering about this reopening when I reviewed the arg_matches PR, but didn't take the time to trace the code.
Fix lgtm!

[steviez]

Ah cool... I was wondering about this reopening when I reviewed the arg_matches PR, but didn't take the time to trace the code.

Ha yup, your comment there was the only reason I noticed this