Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clippy: Removes ineffective open options #34599

Merged
merged 1 commit into from
Dec 28, 2023

Conversation

brooksprumo
Copy link
Contributor

Problem

New clippy lints that need fixing:

error: unnecessary use of `.write(true)` because there is `.append(true)`
  --> logger/src/lib.rs:61:9
   |
61 |         .write(true)
   |         ^^^^^^^^^^^^ help: remove `.write(true)`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ineffective_open_options
   = note: `-D clippy::ineffective-open-options` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(clippy::ineffective_open_options)]`

Summary of Changes

Remove unnecessary .write(true)s.

```
error: unnecessary use of `.write(true)` because there is `.append(true)`
  --> logger/src/lib.rs:61:9
   |
61 |         .write(true)
   |         ^^^^^^^^^^^^ help: remove `.write(true)`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ineffective_open_options
   = note: `-D clippy::ineffective-open-options` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(clippy::ineffective_open_options)]`
```
@brooksprumo brooksprumo self-assigned this Dec 27, 2023
@brooksprumo brooksprumo marked this pull request as ready for review December 27, 2023 22:29
@brooksprumo brooksprumo requested review from joncinque and yihau and removed request for joncinque December 27, 2023 22:30
Copy link

codecov bot commented Dec 27, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (1f7c714) 81.8% compared to head (a570c91) 81.8%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #34599   +/-   ##
=======================================
  Coverage    81.8%    81.8%           
=======================================
  Files         824      824           
  Lines      222261   222260    -1     
=======================================
+ Hits       181889   181965   +76     
+ Misses      40372    40295   -77     

Copy link
Member

@yihau yihau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🫶

@brooksprumo brooksprumo merged commit f8c3e24 into solana-labs:master Dec 28, 2023
35 checks passed
@brooksprumo brooksprumo deleted the clippy/open branch December 28, 2023 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants