ledger-tool: Move ledger output methods to output.rs #34595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steviez
force-pushed
the
lt_x_move_output_functions
branch
from
8e4f2ed
to
506aca7
Compare
3 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #34595 +/- ##
=========================================
- Coverage 81.8% 81.8% -0.1%
=========================================
Files 824 824
Lines 222261 222261
=========================================
- Hits 181893 181864 -29
- Misses 40368 40397 +29 |
CriesofCarrots
previously approved these changes
Jan 3, 2024
steviez
force-pushed
the
lt_x_move_output_functions
branch
from
506aca7
to
8e21099
Compare
steviez
commented
Jan 3, 2024
CriesofCarrots
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
We have a dedicated file for CLI output, so move the various output functions there.
There is probably work to be done to clean up these
output_*()functions; however, I think that should be deferred for the sake of this PR as I have another PR that I would like to have consume this one.