Uses Bank::new_for_tests() instead of new_for_tests_with_config() #34587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brooksprumo
force-pushed
the
ctor/bank/tests
branch
from
cd19d15
to
823ad67
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #34587 +/- ##
=========================================
- Coverage 81.8% 81.8% -0.1%
=========================================
Files 824 824
Lines 222153 222148 -5
=========================================
- Hits 181803 181776 -27
- Misses 40350 40372 +22 |
LucasSte
reviewed
Dec 25, 2023
Comment on lines
+116
to
+117
| let bank_forks = | ||
| BankForks::new_rw_arc(Bank::new_for_tests(&genesis_config_info.genesis_config)); |
There was a problem hiding this comment.
There is a function called Bank::new_with_bank_forks_for_tests that does exactly this.
There was a problem hiding this comment.
Yep! I have follow up PRs planned for more refactors to consolidate the constructors.
I prefer these simpler PR with a single change. It's easy to see they are all the same. And this is correct as is.
| @@ -2130,8 +2130,7 @@ fn test_purge_empty_accounts() { | |||
| let (genesis_config, mint_keypair) = create_genesis_config(sol_to_lamports(1.)); | |||
| let amount = genesis_config.rent.minimum_balance(0); | |||
| let (mut bank, bank_forks) = | |||
| Bank::new_for_tests_with_config(&genesis_config, BankTestConfig::default()) | |||
| .wrap_with_bank_forks_for_tests(); | |||
| Bank::new_for_tests(&genesis_config).wrap_with_bank_forks_for_tests(); | |||
There was a problem hiding this comment.
Bank::new_with_bank_forks_for_tests does this as well.
LucasSte
approved these changes
Dec 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
A number of tests call
Bank::new_for_tests_with_config()even though they don't use thetest_configparameter at all. These could callBank::new_for_tests()instead.Summary of Changes
Replace
new_for_tests_with_config()withnew_for_tests().