Moves Bank benches-only ctors in DCOU #34545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brooksprumo
force-pushed
the
ctor/bank/benches
branch
from
71b287d
to
b780424
Compare
brooksprumo
force-pushed
the
ctor/bank/benches
branch
from
b780424
to
d85b441
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #34545 +/- ##
=========================================
- Coverage 81.8% 81.8% -0.1%
=========================================
Files 822 822
Lines 221540 221540
=========================================
- Hits 181403 181362 -41
- Misses 40137 40178 +41 |
apfitzge
reviewed
Dec 20, 2023
| pub fn new_for_benches(genesis_config: &GenesisConfig) -> Self { | ||
| Self::new_with_paths_for_benches(genesis_config, Vec::new()) | ||
| } | ||
|
|
||
| /// Intended for use by tests only. | ||
| /// create new bank with the given configs. | ||
| pub fn new_with_runtime_config_for_tests( |
There was a problem hiding this comment.
I guess it doesn't fit the title, but shouldn't new_with_runtime_config_for_tests also be either test or dcou?
Oh absolutely yes. Unfortunately it's not that straightforward... Here's what needs to merge first. |
apfitzge
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Bank has constructors that are only called by benches. These should be in a DCOU block.
Summary of Changes
Put 'em in a DCOU block.