-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ledger-tool: add show-entries option to bigtable block #34536
ledger-tool: add show-entries option to bigtable block #34536
Conversation
I kept all the type and output work in |
5a9e3ff
to
286a16d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #34536 +/- ##
=======================================
Coverage 81.8% 81.8%
=======================================
Files 822 822
Lines 221532 221532
=======================================
+ Hits 181307 181328 +21
+ Misses 40225 40204 -21 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
With the way you wrote writeln_entry()
, it seems a follow-up could be to simplify the functions in solana-ledger-tool slot
path (ie output_entry()
)
Agreed! |
Problem
Now that entries are uploaded to bigtable,
solana-ledger-tool bigtable block
can reconstruct complete blocks comparable to the data returned bysolana-ledger-tool slot
.Re: #34266 (review)
Summary of Changes
Add
--show-entries
flag to build block display struct with entriesOutput looks like:
This is similar to what
solana-ledger-tool slot
spits out. The only differences are a lower indent level and metadata (slot
prints SlotMeta,bigtable block
prints the block meta, like parent info and rewards).The output still supports json: