clean up no longer needed feature_set in test #34530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tao-stones
commented
Dec 19, 2023
| @@ -9997,16 +9993,7 @@ fn calculate_test_fee( | |||
| message: &SanitizedMessage, | |||
| lamports_per_signature: u64, | |||
| fee_structure: &FeeStructure, | |||
| support_set_accounts_data_size_limit_ix: bool, | |||
There was a problem hiding this comment.
the name of this parameter is misleading
tao-stones
commented
Dec 19, 2023
| &solana_sdk::feature_set::include_loaded_accounts_data_size_in_fee_calculation::id(), | ||
| ); | ||
| } | ||
|
|
There was a problem hiding this comment.
the feature_set is no longer used. calculate_fee() takes hard-coded false to exclude account bytes from fee calc.
apfitzge
approved these changes
Dec 19, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #34530 +/- ##
=======================================
Coverage 81.8% 81.8%
=======================================
Files 822 822
Lines 221532 221518 -14
=======================================
+ Hits 181307 181348 +41
+ Misses 40225 40170 -55 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
A test function no longer need to use feature_set; it also uses wrong variable name;
Summary of Changes
Fixes #