add rpc change to changelog #34511
Merged
add rpc change to changelog #34511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willhickey
approved these changes
Dec 18, 2023
| @@ -24,6 +24,7 @@ Release channels have their own copy of this changelog: | |||
| feature would have prevented it | |||
| * Updated local ledger storage so that the RPC endpoint | |||
| `getSignaturesForAddress` always returns signatures in block-inclusion order | |||
| * RPC's `simulate_transaction` now returns `inner_instructions` as `json`/`jsonParsed` (#34313). | |||
There was a problem hiding this comment.
Since this change doesn't affect send (the other caller of the internal simulate method), I would change this to simulateTransaction to refer to the RPC endpoint.
Ditto camel casing innerInstructions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Adds the recent
simulate_transactionchanges to the changelog.