Remove ledger-tool-specific output format enum #34473
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Support for json output from cli tools has developed in a haphazard way. As result, there are inconsistent and sometimes duplicate implementations of things. For example,
solana-ledger-tool
uses bothsolana_cli_output::OutputFormat
and its own hand-rolled output format enum in various places to track the desired output format. This makes it harder than it needs to be to make consistent the actual strings that get printed.Summary of Changes
Remove
solana_ledger_tool::LedgerOutputMethod
This makes no functional changes to the subcomands that used it; ie. the actual output format is still hard-coded in the subcommand match