-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typos #34459
Fix typos #34459
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Just a couple of adjustments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In-code changes, like variable names or filenames need to be handled more carefully than comments.
I commented on one such issue (and you can see it failed CI).
Can you please separate the in-code changes into one or more separate commits from corrections in comments/docs?
@CriesofCarrots @samkim-crypto @buffalojoec Thanks for your reviews. And I have resolved and separated the in-code changes from corrections in comments/docs. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #34459 +/- ##
=========================================
- Coverage 81.8% 81.8% -0.1%
=========================================
Files 822 822
Lines 221587 221587
=========================================
- Hits 181413 181356 -57
- Misses 40174 40231 +57 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you
Sorry about the CI failure. Can you please rebase to pick up the dependency bump?
|
automerge label removed due to a CI failure |
Wtf, github? I didn't re-add the CI label |
Fix typos caught by codespell tool