Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos #34459

Merged
merged 5 commits into from
Dec 21, 2023
Merged

Fix typos #34459

merged 5 commits into from
Dec 21, 2023

Conversation

GoodDaisy
Copy link
Contributor

Fix typos caught by codespell tool

@mergify mergify bot added community Community contribution need:merge-assist labels Dec 14, 2023
@mergify mergify bot requested a review from a team December 14, 2023 12:24
Copy link
Contributor

@buffalojoec buffalojoec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just a couple of adjustments.

runtime/src/snapshot_utils.rs Outdated Show resolved Hide resolved
runtime/src/snapshot_utils.rs Outdated Show resolved Hide resolved
transaction-dos/src/main.rs Outdated Show resolved Hide resolved
@CriesofCarrots CriesofCarrots added the CI Pull Request is ready to enter CI label Dec 14, 2023
@solana-grimes solana-grimes removed the CI Pull Request is ready to enter CI label Dec 14, 2023
Copy link
Contributor

@CriesofCarrots CriesofCarrots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In-code changes, like variable names or filenames need to be handled more carefully than comments.
I commented on one such issue (and you can see it failed CI).

Can you please separate the in-code changes into one or more separate commits from corrections in comments/docs?

accounts-db/src/accounts_db.rs Outdated Show resolved Hide resolved
@GoodDaisy
Copy link
Contributor Author

@CriesofCarrots @samkim-crypto @buffalojoec Thanks for your reviews.

And I have resolved and separated the in-code changes from corrections in comments/docs.

Copy link

codecov bot commented Dec 17, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (1358c19) 81.8% compared to head (6e3eeda) 81.8%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master   #34459     +/-   ##
=========================================
- Coverage    81.8%    81.8%   -0.1%     
=========================================
  Files         822      822             
  Lines      221587   221587             
=========================================
- Hits       181413   181356     -57     
- Misses      40174    40231     +57     

Copy link
Contributor

@CriesofCarrots CriesofCarrots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@CriesofCarrots CriesofCarrots added the CI Pull Request is ready to enter CI label Dec 18, 2023
@solana-grimes solana-grimes removed the CI Pull Request is ready to enter CI label Dec 18, 2023
@CriesofCarrots
Copy link
Contributor

CriesofCarrots commented Dec 18, 2023

Sorry about the CI failure. Can you please rebase to pick up the dependency bump?

git pull --rebase <upstream> master
git push -f

@CriesofCarrots CriesofCarrots added the CI Pull Request is ready to enter CI label Dec 21, 2023
@solana-grimes solana-grimes removed the CI Pull Request is ready to enter CI label Dec 21, 2023
@CriesofCarrots CriesofCarrots added CI Pull Request is ready to enter CI automerge Merge this Pull Request automatically once CI passes labels Dec 21, 2023
@solana-grimes solana-grimes removed CI Pull Request is ready to enter CI labels Dec 21, 2023
Copy link
Contributor

mergify bot commented Dec 21, 2023

automerge label removed due to a CI failure

@mergify mergify bot removed the automerge Merge this Pull Request automatically once CI passes label Dec 21, 2023
@CriesofCarrots
Copy link
Contributor

Wtf, github? I didn't re-add the CI label

@CriesofCarrots CriesofCarrots merged commit 03386cc into solana-labs:master Dec 21, 2023
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Community contribution need:merge-assist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants