-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only allow BankForks creation with single bank #34449
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the unit test for that behavior as well
steviez
commented
Dec 13, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #34449 +/- ##
=========================================
- Coverage 81.8% 81.8% -0.1%
=========================================
Files 819 819
Lines 220923 220907 -16
=========================================
- Hits 180870 180844 -26
- Misses 40053 40063 +10 |
apfitzge
reviewed
Dec 14, 2023
We know BankForks has exactly one root at this point, so looping is confusing / slightly wasteful
apfitzge
approved these changes
Dec 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
BankForks has two constructors; one that takes a single Bank (the root) and one that can take an arbitrary number of Banks plus the root slot. However, the constructor that accepts multiple banks is unnecessary; it isn't used in production and is only used in several tests.
Summary of Changes