Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sets EpochAccountsHash to Valid in accounts bench #34420

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

brooksprumo
Copy link
Contributor

Problem

While removing the featurization code for EpochAccountsHash, a bench failed because EAH was now enabled.

Summary of Changes

Set EAH to Valid so that Bank::new_from_parent() doesn't panic during freeze.

@brooksprumo brooksprumo self-assigned this Dec 12, 2023
@brooksprumo brooksprumo marked this pull request as ready for review December 12, 2023 20:25
@jeffwashington
Copy link
Contributor

did you find this while running accounts bench somehow? when the feature was activated?

Copy link
Contributor

@jeffwashington jeffwashington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@brooksprumo
Copy link
Contributor Author

did you find this while running accounts bench somehow? when the feature was activated?

CI found it. In removing the EAH feature gate (#34417), it effectively makes EAH always ON where it used to be OFF. Since this bench runs through enough banks to make it into the EAH window, it now has to follow the EAH rules.

@brooksprumo brooksprumo added the automerge Merge this Pull Request automatically once CI passes label Dec 12, 2023
Copy link

codecov bot commented Dec 12, 2023

Codecov Report

Merging #34420 (9bd3097) into master (39a3566) will increase coverage by 0.0%.
Report is 7 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #34420   +/-   ##
=======================================
  Coverage    81.9%    81.9%           
=======================================
  Files         819      819           
  Lines      220984   220984           
=======================================
+ Hits       181015   181034   +19     
+ Misses      39969    39950   -19     

@mergify mergify bot merged commit 79d0a47 into solana-labs:master Dec 12, 2023
35 checks passed
@brooksprumo brooksprumo deleted the eah/set-valid branch December 12, 2023 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge this Pull Request automatically once CI passes
Projects
Development

Successfully merging this pull request may close these issues.

2 participants