Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up prevent_rent_paying_rent_recipients feature #34418

Merged

Conversation

CriesofCarrots
Copy link
Contributor

Problem

Feature Fab5oP3DmsLYCiQZXdjyqT3ukFFPrsmqhXU4WU1AWVVF: prevent_rent_paying_rent_recipients has been activated on all clusters.

Summary of Changes

Clean up feature gating
Probably easiest to review without whitespace changes, as the bulk of the lines changed are simply indented less.

Closes #30151

@CriesofCarrots
Copy link
Contributor Author

@jstarry , hope you're willing to review. I picked you because of the interactions with the rework you recently did in this area.

Copy link

codecov bot commented Dec 12, 2023

Codecov Report

Merging #34418 (d2148f0) into master (07f3883) will increase coverage by 0.0%.
Report is 3 commits behind head on master.
The diff coverage is 100.0%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #34418   +/-   ##
=======================================
  Coverage    81.8%    81.9%           
=======================================
  Files         819      819           
  Lines      221019   220997   -22     
=======================================
+ Hits       180975   181017   +42     
+ Misses      40044    39980   -64     

@CriesofCarrots
Copy link
Contributor Author

@brooksprumo , since you were a reviewer on Justin's PR, can you take a look at this?

Copy link
Contributor

@brooksprumo brooksprumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - diff was quite minimal when ignoring whitespace, like you suggested!

@CriesofCarrots CriesofCarrots merged commit b0c54d3 into solana-labs:master Dec 14, 2023
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Gate: Prevent RentPaying rent recipients
2 participants