Unhide --block-production-method

[apfitzge]

Problem

• New scheduler is in, there's more than one option here, it shouldn't be hidden.
• I forgot to do this previously

Summary of Changes

• Don't hide the --block-production-method cli arg for validator

Fixes #

[codecov]

Codecov Report

Merging #34416 (87d23c8) into master (4b76232) will increase coverage by 0.0%.
Report is 5 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files

@@           Coverage Diff           @@
##           master   #34416   +/-   ##
=======================================
  Coverage    81.8%    81.8%           
=======================================
  Files         819      819           
  Lines      220978   220976    -2     
=======================================
+ Hits       180971   180976    +5     
+ Misses      40007    40000    -7     

[steviez]

I'm not the most familiar with all of the underlying work that this would enable but to confirm - all of the available BlockProductionMethod modes are ready for further testing / evaluation on testnet ?

Also, no need to get a ship-it from me to submit; happened upon this PR by skimming the list looking for something else

[tao-stones]

lgtm

[apfitzge]

all of the available BlockProductionMethod modes are ready for further testing / evaluation on testnet ?

Yep. There was previously only 1 variant thread-local-multi-iterator which corresponds to the old BankingStage. A new variant, central-scheduler, was added recently. I did not realize that the argument was hidden when I added the new variant, otherwise I'd have unhidden it when I added it then.

[steviez]

all of the available BlockProductionMethod modes are ready for further testing / evaluation on testnet ?

Yep. There was previously only 1 variant thread-local-multi-iterator which corresponds to the old BankingStage. A new variant, central-scheduler, was added recently. I did not realize that the argument was hidden when I added the new variant, otherwise I'd have unhidden it when I added it then.

Sweet. Once we take testnet v1.18, we can probably either switch some of our nodes over and/or ask for volunteers to give it a go