Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switches order of tiered storage footer size and version #34310

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

brooksprumo
Copy link
Contributor

Problem

Original comment from #34200 (comment):

I think footer_version needs to be processed before footer_size (otherwise we actually don't know the correct size of that version).

Summary of Changes

Switch the order of the footer size and the footer version within the footer.

@brooksprumo brooksprumo self-assigned this Dec 3, 2023
Copy link

codecov bot commented Dec 4, 2023

Codecov Report

Merging #34310 (36efed1) into master (8fbe033) will decrease coverage by 0.1%.
The diff coverage is 81.8%.

Additional details and impacted files
@@            Coverage Diff            @@
##           master   #34310     +/-   ##
=========================================
- Coverage    81.9%    81.9%   -0.1%     
=========================================
  Files         819      819             
  Lines      220084   220084             
=========================================
- Hits       180347   180344      -3     
- Misses      39737    39740      +3     

@brooksprumo brooksprumo marked this pull request as ready for review December 4, 2023 01:21
Copy link
Contributor

@yhchiang-sol yhchiang-sol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG. Thank you!!

@brooksprumo brooksprumo merged commit 2c033e0 into solana-labs:master Dec 4, 2023
33 checks passed
@brooksprumo brooksprumo deleted the ts/footer-order branch December 4, 2023 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tiered storage: Footer deserialization has undefined behavior/needs sanitization
2 participants