Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag InterestingLimit enum with target_os #34259

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

CriesofCarrots
Copy link
Contributor

Problem

#34149 added some target_os = "linux" handling, but the accompanying enum is not tagged, leading to clippy complaints on other OSes, like mac:

warning: variants `Recommend` and `QueryOnly` are never constructed
   --> core/src/system_monitor_service.rs:397:5
    |
396 | enum InterestingLimit {
    |      ---------------- variants in this enum
397 |     Recommend(i64),
    |     ^^^^^^^^^
398 |     QueryOnly,
    |     ^^^^^^^^^
    |
    = note: `#[warn(dead_code)]` on by default

warning: `solana-core` (lib) generated 1 warning

Summary of Changes

Tag the enum

Copy link
Contributor

@t-nelson t-nelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only linux has interesting limits

true. thanks! :shipit:

@CriesofCarrots CriesofCarrots added the automerge Merge this Pull Request automatically once CI passes label Nov 28, 2023
@mergify mergify bot removed the automerge Merge this Pull Request automatically once CI passes label Nov 28, 2023
Copy link
Contributor

mergify bot commented Nov 28, 2023

automerge label removed due to a CI failure

@CriesofCarrots CriesofCarrots added the automerge Merge this Pull Request automatically once CI passes label Nov 29, 2023
@mergify mergify bot merged commit 2bde5c3 into solana-labs:master Nov 29, 2023
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge this Pull Request automatically once CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants