Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TransactionScheduler: check transaction age and already processed during receive #34253

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

apfitzge
Copy link
Contributor

Problem

Some transactions we receive may be too old or already processed, but they still make it into the buffer temporarily.

Summary of Changes

  • Filter these transactions out before inserting to buffer

Fixes #

Copy link

codecov bot commented Dec 1, 2023

Codecov Report

Merging #34253 (545a2d2) into master (18309ba) will decrease coverage by 0.1%.
Report is 1 commits behind head on master.
The diff coverage is 95.5%.

Additional details and impacted files
@@            Coverage Diff            @@
##           master   #34253     +/-   ##
=========================================
- Coverage    81.9%    81.9%   -0.1%     
=========================================
  Files         819      819             
  Lines      219969   219997     +28     
=========================================
- Hits       180326   180260     -66     
- Misses      39643    39737     +94     

@apfitzge apfitzge marked this pull request as ready for review December 1, 2023 15:56
Copy link
Contributor

@tao-stones tao-stones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@apfitzge apfitzge merged commit d451675 into solana-labs:master Dec 4, 2023
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants