Move Gossip values added for wen_retart into restart_crds_values. #34128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #34128 +/- ##
==========================================
Coverage 81.8% 81.9%
==========================================
Files 766 819 +53
Lines 209158 220019 +10861
==========================================
+ Hits 171210 180281 +9071
- Misses 37948 39738 +1790 |
behzadnouri
reviewed
Nov 17, 2023
gossip/src/wen_restart_values.rs
Outdated
There was a problem hiding this comment.
Can we name this file restart_crds_values.rs?
gossip/src/wen_restart_values.rs
Outdated
| LastVotedForkEmpty, | ||
| } | ||
|
|
||
| impl RestartLastVotedForkSlots { |
There was a problem hiding this comment.
Can you please move all enum/struct type definitions first in the file, and then followed by impl?
Also please put more prominent types first, then the inner/private types; e.g. RestartLastVotedForkSlots should go first.
behzadnouri
previously approved these changes
Nov 17, 2023
behzadnouri
previously approved these changes
Nov 17, 2023
wen-coding
changed the title
behzadnouri
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Group Gossip values added for wen_restart into one single file.
Summary of Changes
Move RestartLastVotedForkSlots into wen_restart_values