Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrades Rust to 1.74.0 #34118

Merged
merged 2 commits into from
Nov 20, 2023
Merged

Conversation

brooksprumo
Copy link
Contributor

  • Upgrades stable Rust to 1.74.0
  • Upgrades nightly Rust to 2023-11-16

https://blog.rust-lang.org/2023/11/16/Rust-1.74.0.html

@brooksprumo
Copy link
Contributor Author

@yihau I know you've already seen this PR; can you update the CI agents with this new rust?

@yihau
Copy link
Member

yihau commented Nov 16, 2023

sure! just restarted your pipeline!

@brooksprumo
Copy link
Contributor Author

Current clippy build error is getting fixed here: #34119

@brooksprumo
Copy link
Contributor Author

Fixing bigtable clippy error here: #34126

Copy link

codecov bot commented Nov 18, 2023

Codecov Report

Merging #34118 (46ae7a8) into master (07f1709) will decrease coverage by 0.1%.
Report is 1 commits behind head on master.
The diff coverage is 100.0%.

Additional details and impacted files
@@            Coverage Diff            @@
##           master   #34118     +/-   ##
=========================================
- Coverage    81.9%    81.8%   -0.1%     
=========================================
  Files         819      819             
  Lines      220120   219077   -1043     
=========================================
- Hits       180367   179295   -1072     
- Misses      39753    39782     +29     

@brooksprumo brooksprumo marked this pull request as ready for review November 18, 2023 19:21
Copy link
Member

@yihau yihau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪖

@brooksprumo brooksprumo merged commit f9b96fa into solana-labs:master Nov 20, 2023
31 checks passed
@brooksprumo brooksprumo deleted the rust/1.74.0 branch November 20, 2023 03:25
rayanebel pushed a commit to rayanebel/solana that referenced this pull request Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants