RuntimeTransaction: Minor Cleanup #34112
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Following up on some minor thoughts I had from #33471.
Summary of Changes
pub(crate)
The change of visibility on the TransactionMeta setters helps us, because if we forget to set a field in either
try_from
of theStatic
orDynamic
RuntimeTransaction
the compiler will mark these as unused/dead code and warn us the field isn't ever being set.Fixes #