Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RuntimeTransaction: Minor Cleanup #34112

Merged
merged 3 commits into from
Nov 16, 2023

Conversation

apfitzge
Copy link
Contributor

Problem

Following up on some minor thoughts I had from #33471.

Summary of Changes

  • Remove simple comments which repeat field names
  • TransactionMeta setters become pub(crate)
  • Module level comment using //! instead of ///

The change of visibility on the TransactionMeta setters helps us, because if we forget to set a field in either try_from of the Static or Dynamic RuntimeTransaction the compiler will mark these as unused/dead code and warn us the field isn't ever being set.

Fixes #

@apfitzge apfitzge marked this pull request as ready for review November 16, 2023 16:11
@apfitzge apfitzge changed the title Remove redundant comments RuntimeTransaction: Minor Cleanup Nov 16, 2023
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Merging #34112 (7d1f761) into master (60fdd85) will increase coverage by 0.0%.
Report is 1 commits behind head on master.
The diff coverage is 0.0%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #34112   +/-   ##
=======================================
  Coverage    81.9%    81.9%           
=======================================
  Files         816      816           
  Lines      219751   219751           
=======================================
+ Hits       180027   180034    +7     
+ Misses      39724    39717    -7     

Copy link
Contributor

@tao-stones tao-stones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@apfitzge apfitzge merged commit e589c07 into solana-labs:master Nov 16, 2023
32 checks passed
@apfitzge apfitzge deleted the runtime_transaction_follow_up branch November 16, 2023 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants